Internal Camera 구현 및 실행 [#110] #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ing03201
commented
Sep 22, 2025
ing03201
commented
- [Issue] Internal Camera 구현 #45 [CameraScreen] 리팩터링 #110
- [Descriptions]
- InternalCameraScreen 생성
- InternalCameraViewModel 생성
- ImageRepository cameraType별로 Uri 수정
…een and update InternelCameraViewModel with capture functionality
DokySp
changed the title
DokySp
changed the title
DokySp
changed the title
DokySp
requested changes
Sep 23, 2025
|
|
||
| // network | ||
| const val WEB_SERVER_URL = "https://4cuts.store/" | ||
| const val WEB_SERVER_URL = "https://foke.clon.dev/" |
Member
There was a problem hiding this comment.
base url 변경 건은 다른 리뷰로 올리면 좋을 것 같아요~
presenter/src/main/java/com/foke/together/presenter/navigation/NavGraph.kt
Show resolved
Hide resolved
presenter/src/main/java/com/foke/together/presenter/navigation/NavGraph.kt
Show resolved
Hide resolved
| class ImageRepository @Inject constructor( | ||
| @ApplicationContext private val context: Context | ||
| @ApplicationContext private val context: Context, | ||
| private val getCameraSourceTypeUseCase: GetCameraSourceTypeUseCase |
Member
There was a problem hiding this comment.
해당 의존성은 사용하지 않고 구조상 애매한 부분이 있어 일단 삭제하는게 좋을 것 같습니다~
- 구조 관련 내용: 프로젝트 모듈 구조 리뷰 #17
| // TODO: 추후 세션 관리와 엮어서 처리하기 | ||
| @Deprecated("Not in use") | ||
| fun getCapturedImageListUri(): List<Uri> = imageRepositoryInterface.getCachedImageUriList() | ||
| fun getCapturedImageListUri(sourceType: CameraSourceType): List<Uri> = imageRepositoryInterface.getCachedImageUriList(sourceType) |
Member
There was a problem hiding this comment.
GeneratePhotoFrameUseCaseV1 을 deprecated한 이유가 Session으로 전환 작업을 위한 내용이었는데
아래 커밋 참고해보면 좋을 것 같습니다~
- 세션 고도화: Session 고도화 #121
Member
Author
There was a problem hiding this comment.
해당 내용은 InternalCamera로 기존 기초적인 실행을 위해 인자를 추가했습니다.
Deprecated 된 함수인건 확인하고있습니다.
DokySp
approved these changes
Sep 25, 2025
fetiu
approved these changes
Sep 25, 2025
Member
fetiu
left a comment
fetiu
left a comment
There was a problem hiding this comment.
제가 코드 구현 측면에서 리뷰드릴 것은 없는 것 같습니다.
수고 너무 많으셨습니다.
사소하게 URI 최신화 관련해서 댓글 달았으니 다음 PR 등에서 적용되었으면 좋겠네요!
| MediaStore.Images.Media.DATE_ADDED | ||
| ) | ||
| val selection = "${MediaStore.Images.Media.RELATIVE_PATH} LIKE ?" | ||
| val selectionArgs = arrayOf("%Pictures/4cuts/backup%") |
Member
There was a problem hiding this comment.
NIT: 4cuts 를 4cut 단수형으로 바꿀 필요가 있을까 궁금합니다!
| val contentValues = ContentValues().apply { | ||
| put(MediaStore.MediaColumns.DISPLAY_NAME, "${fileName}.jpg") | ||
| put(MediaStore.MediaColumns.MIME_TYPE, "image/jpeg") | ||
| put(MediaStore.Images.Media.RELATIVE_PATH, "Pictures/4cuts/backup") |
Member
There was a problem hiding this comment.
NIT: 동일하게 cuts를 cut으로 바꿀 필요가 있을지 궁금합니다!
| AppLog.d(TAG, "generateQRcode" ,"result: $result") | ||
|
|
||
| val downloadUrl: String = getDownloadUrlUseCase(sessionKey).getOrElse { "https://4cuts.store" } | ||
| val downloadUrl: String = getDownloadUrlUseCase(sessionKey).getOrElse { "https://foke.clon.dev" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.