Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isspace #451

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Add isspace #451

merged 5 commits into from
Oct 20, 2023

Conversation

kant2002
Copy link
Collaborator

No description provided.

@kant2002
Copy link
Collaborator Author

Now I'm curious what locale settings on Github CI is set.

@ForNeVeR ForNeVeR self-assigned this Oct 17, 2023
@ForNeVeR
Copy link
Owner

This wasn't an issue of locale, but instead the formatting for UIntPtr was broken on .NET Framework: the behavior of string.Format("{0:x2}", (IntPtr)0x20) is different between net48 and net7.

I've fixed that with more portable code.

Good thing we have the integration tests :)

ForNeVeR
ForNeVeR approved these changes Oct 20, 2023
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit 9a7713a into ForNeVeR:main Oct 20, 2023
3 checks passed
ForNeVeR added a commit that referenced this pull request Oct 20, 2023
@ForNeVeR
(#451) FPrintF: fix behavior on .NET Framework
e8eab31
ForNeVeR added a commit that referenced this pull request Oct 20, 2023
@ForNeVeR
(#451) Code cleanup
04005f0
@kant2002 kant2002 deleted the kant/add-isspace branch September 8, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@ForNeVeR ForNeVeR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kant2002 @ForNeVeR