Simplify declarations #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We somehow have 3 types of large IR structures, expressions, block items and declarations. If expression and block items is somewhat simple things, which follow rules, declaration is a thing in it's own which behave as block item, but do not have any lowering, even if they have tree structure. This simplifies declarations a bit, and remove nesting. Place multiple declarations into compound statement. I'm not sure that this is last refactoring of this area, but at least this is gives idea of what should be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We somehow have 3 types of large IR structures, expressions, block items and declarations. If expression and block items is somewhat simple things, which follow rules, declaration is a thing in it's own which behave as block item, but do not have any lowering, even if they have tree structure. This simplifies declarations a bit, and remove nesting. Place multiple declarations into compound statement.
I'm not sure that this is last refactoring of this area, but at least this is gives idea of what should be done.