Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation component #1082

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomasvn
Copy link

@tomasvn tomasvn commented Oct 30, 2024

Description

Add new story with arrows enabled, update styles, changed contributing guide, updated navigation to use button elements

Fixes #1081 (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project (I have run pnpm run lint)

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes (I have run pnpm run test:ci-with-server/pnpm run test)

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • I have recorded any user-facing fixes or changes with pnpm changeset.

  • My changes generate no new warnings

  • Any dependent changes have been merged and published in downstream modules

  • I have tried to run test via pnpm run check, but test would throw warnings with

console.error
      Warning: `ReactDOMTestUtils.act` is deprecated in favor of `React.act`. Import `act` from `react` instead of `react-dom/test-utils`. See https://react.dev/warnings/react-dom-test-utils for more info.

Add new story, update styles, changed contributing guide
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuka-carousel-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:51pm

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 653a62d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nuka-carousel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

windows narrator would read only numbers without extra context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace div elements for native button elements
1 participant