Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Default props #380

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Remove Default props #380

merged 2 commits into from
Feb 2, 2024

Conversation

moshie
Copy link
Contributor

@moshie moshie commented Jan 28, 2024

Fixes: #339

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-live-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 5:37pm

@moshie
Copy link
Contributor Author

moshie commented Jan 28, 2024

@carloskelly13 FYI

@carloskelly13
Copy link
Contributor

carloskelly13 commented Jan 29, 2024

@moshie This looks good to me, I'm no longer with Formidable, but I'd also suggest a patch-version changeset so a release can be cut. I've pinged some folks to get this merged along.

@moshie
Copy link
Contributor Author

moshie commented Jan 31, 2024

@moshie This looks good to me, I'm no longer with Formidable, but I'd also suggest a patch-version changeset so a release can be cut. I've pinged some folks to get this merged along.

Thanks! I'll get that done

@keithluchtel keithluchtel merged commit 22e348e into FormidableLabs:master Feb 2, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
@moshie moshie deleted the fix-default-props branch February 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To use JavaScript default props instead of defaultProps
3 participants