fix: fixed the logic for scroll event on zoom-voronoi container #3060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
This change updates the default
eventHandlers
inVictoryZoomContainer.defaultEvents
so that theonWheel
handler is only attached whenprops.allowZoom
is true. Previously, theonWheel
handler was always registered (but disabled via the handler’sdisabled
flag), which could still trigger unnecessary event binding and potential side effects.Fixes:
Prevents
onWheel
from being registered whenallowZoom
is false.Motivation and Context:
VictoryZoomContainer
.props.allowZoom
inside the handler body for wheel events.Dependencies:
defaultEvents
configuration invictory-zoom-container.js
and does not introduce new dependencies.Fixes # (issue)
Type of Change