chore: remove version number from package.json for each library
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... "it works on my machine". I'll give this a closer look soon. |
jemc
force-pushed
the
chore/remove-package-json-version
branch
from
4471564 to
e514428
Compare
We are using `semantic-release` which overrides the number in `package.json` with an appropriate version number and doesn't commit it back to git. To understand the reasons why it doesn't, please see this FAQ entry: https://github.com/semantic-release/semantic-release/blob/73bcd0bcdb98322c5c5224ffb55960de114c3fd1/docs/support/FAQ.md#why-is-the-packagejsons-version-not-updated-in-my-repository But having the `version` numbers in our repository is potentially confusing because people may look to that field to see what the latest version is. So this commit updates our repo to use the value `1.0.0-semantically-released`, as per the recommendation of that same FAQ entry (but using `1` as the major version so as not to break `pnpm` tooling), so we can use a less confusing value that points to the right way to see our latest version, while still technically adhering to the requirements of the `package.json` format about a version number being present and using a valid version format.
jemc
force-pushed
the
chore/remove-package-json-version
branch
from
e514428 to
d7082fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
semantic-releasewhich overrides the number inpackage.jsonwith an appropriate version number and doesn't commit it back to git. To understand the reasons why it doesn't, please see this FAQ entry: https://github.com/semantic-release/semantic-release/blob/73bcd0bcdb98322c5c5224ffb55960de114c3fd1/docs/support/FAQ.md#why-is-the-packagejsons-version-not-updated-in-my-repositoryBut having the
versionnumbers in our repository is potentially confusing because people may look to that field to see what the latest version is.So this commit updates our repo to use the value
0.0.0-semantically-released, as per the recommendation of that same FAQ entry, so as to use a less confusing value that points to the right way to see our latest version, while still technically adhering to the requirements of thepackage.jsonformat about a version number being present and using a valid version format.