Support for OAuth2::Response #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send_request is based on Net::Http. New version of OAuth2 library uses OAuth2Response based on Faraday. Modified send_request to include support for OAuth2::Response AND Net::Http.
|
Any chance this will be merged soon? Thanks! |
Quick hack to upgrade management API to GData v 2.4. Main change is the response is XML only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google API now supports OAuth2. The OAuth2 gem uses Faraday wrapped by its own OAuth2::Response class. This class behaves differently than Net::HTTP that the OAuth gem depends on. The key difference is that OAuth2::Response exposes a method OAuth2::Response#status that returns the status code for the request.
Modified Garb::Request::Data##send_request to check for Net::HTTPSuccess or status = 200 on the response. If neither are present, raise ClientError and return the body of the response.