Skip to content

testing and improvements for artist string parsing #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FoxxMD
Copy link
Owner

@FoxxMD FoxxMD commented Jan 27, 2025

Checklist before requesting a review

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Describe your changes

  • Implement faker data generation for artist string
  • Add test suite for parsing different styles of artist strings

@FoxxMD FoxxMD force-pushed the improvedArtistStringParsing branch from 17722ef to 8053a8f Compare March 13, 2025 15:08
FoxxMD added 2 commits March 19, 2025 17:04
* Implement faker data generation for artist string
* Add test suite for parsing different styles of artist strings
* Use more context-aware list parsing with ampersands
* Ignore artists with slashes when wrapped by word-boundary
@FoxxMD FoxxMD force-pushed the improvedArtistStringParsing branch from 8053a8f to 3c3492e Compare March 19, 2025 19:54
@FoxxMD FoxxMD added enhancement New feature or request safe to test trusted to build image labels Mar 19, 2025
@FoxxMD FoxxMD marked this pull request as ready for review March 19, 2025 19:55
@FoxxMD FoxxMD changed the title WIP testing and improvements for artist string parsing testing and improvements for artist string parsing Mar 19, 2025
Copy link
Contributor

📦 A new release has been made for this pull request.

To play around with this PR, pull an image:

  • foxxmd/multi-scrobbler:pr-260

Images are available for x86_64 and ARM64.

Latest commit: 3c3492e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request safe to test trusted to build image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant