Skip to content

feat: Implement POC global request interceptor and curl command #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FoxxMD
Copy link
Owner

@FoxxMD FoxxMD commented Mar 21, 2025

Checklist before requesting a review

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Describe your changes

  • Use @msjw/interceptors to intercept all HTTP requests and implement scoped listeners for capturing request/response for specific action
  • Use curl-generator to generate a reproducible request from captured request
  • Add to LFM client to log scrobbles that result in an error or ignored scrobble

@FoxxMD FoxxMD added enhancement New feature or request safe to test trusted to build image labels Mar 21, 2025
@FoxxMD FoxxMD force-pushed the requestIntercept branch from 62b0d15 to 348a6d9 Compare March 26, 2025 15:06
@FoxxMD FoxxMD force-pushed the requestIntercept branch from 740d208 to 44f6639 Compare March 26, 2025 15:42
Copy link
Contributor

📦 A new release has been made for this pull request.

To play around with this PR, pull an image:

  • foxxmd/multi-scrobbler:pr-284

Images are available for x86_64 and ARM64.

Latest commit: 44f6639

@FoxxMD
Copy link
Owner Author

FoxxMD commented Apr 28, 2025

In previous testing on production this was causing a big memory leak. Probably not handling listeners very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request safe to test trusted to build image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant