-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README Refactor #8
README Refactor #8
Conversation
- Taking [3] into account. - Moved Google EC docs into separate file. - General Formatting [3]:FrameworkComputer#3
Besides my pull request I was also wondering:
|
I would rather recommend using collapsible markdown instead of moving the text to another file, but i agree that the current readme is ugly to look at. Collapsible markdown example: https://gist.github.com/joyrexus/16041f2426450e73f5df9391f7f7ae5f |
Sure, will do. I know how to use them, still thank |
Given that this project is based on the upstream Chromium EC, it would be better to keep their repo layout. It’s pretty logically organized: it’s a repository of code, so it wouldn’t be meaningful to hide the code another layer deep. :) |
That honestly just sounds like a lazy excuse not to put in some work and use best practices in repository management, don't you agree? And the points that @ElectronicsArchiver brought up are valid. |
So? Just because the repos focus is a software project doesn't mean In fact, no repo should do that regardless of content, Besides, having that many items in the root folder This would be like filling your apartment with The upstream part however is a good point, Oh Risae just commented, well I'll still post it. |
I don't think it's a lazy excuse. When there is the upstream of this repository, it's important to minimize the difference between this repository (downstream) and the upstream to make the backporting easier. When I want to fix a part of the upstream in a downstream repository, I always try to fix the part on the upstream first, then backport it to the downstream. This approach in the contribution is called "Upstream First". You can search by "Upstream First", then you can find some documents. |
➜ Preview