Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overload operator-> for CallExpression #1842

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

peckto
Copy link
Collaborator

@peckto peckto commented Nov 14, 2024

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (47d6f94) to head (fe1ce47).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 87.14% <66.66%> (-0.60%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

callee.language is HasOperatorOverloading &&
callee is MemberExpression &&
callee.operatorCode == "->" &&
callee.base.type !is PointerType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pretty much have the same code for member access. Is it possible to extract it unto a common function?

@peckto
Copy link
Collaborator Author

peckto commented Nov 14, 2024

Can someone explain to me, why the codecov/patch QA fails? I don't get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants