-
Notifications
You must be signed in to change notification settings - Fork 88
Fix CDG for ShortCircuitOperators #2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KuechA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good overall and we should merge it asap @maximiliankaul. The original base branch is now merged on main. Just a small comment where I'm not sure why we implemented it that way
| val nextRelevantEOGEdges = currentStartNode.nextEOGEdges | ||
| // Note: This may not identify all cases correctly, e.g., if a ShortCircuitOperator is | ||
| // not the direct astParent. | ||
| val shortCircuit = currentStartNode.astParent as? ShortCircuitOperator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to make the look-ahead in the EOG here instead of checking the astParent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try that.
Fixes #2486