Skip to content

Conversation

@maximiliankaul
Copy link
Contributor

Fixes #2486

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.42%. Comparing base (b403be9) to head (5c72300).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nhofer/aisec/cpg/passes/BasicBlockCollectorPass.kt 50.00% 4 Missing and 2 partials ⚠️
...fer/aisec/cpg/passes/ControlDependenceGraphPass.kt 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...in/de/fraunhofer/aisec/cpg/graph/builder/Fluent.kt 85.51% <100.00%> (+0.22%) ⬆️
.../fraunhofer/aisec/cpg/graph/overlays/BasicBlock.kt 59.45% <100.00%> (-1.52%) ⬇️
.../de/fraunhofer/aisec/cpg/frontends/TestLanguage.kt 85.00% <100.00%> (+1.21%) ⬆️
...fer/aisec/cpg/passes/ControlDependenceGraphPass.kt 80.95% <40.00%> (+2.18%) ⬆️
...nhofer/aisec/cpg/passes/BasicBlockCollectorPass.kt 83.92% <50.00%> (-9.55%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KuechA KuechA changed the base branch from main to ak/try-to-fix-merge-points December 18, 2025 08:23
@KuechA KuechA changed the base branch from ak/try-to-fix-merge-points to main January 8, 2026 13:13
Copy link
Contributor

@KuechA KuechA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good overall and we should merge it asap @maximiliankaul. The original base branch is now merged on main. Just a small comment where I'm not sure why we implemented it that way

val nextRelevantEOGEdges = currentStartNode.nextEOGEdges
// Note: This may not identify all cases correctly, e.g., if a ShortCircuitOperator is
// not the direct astParent.
val shortCircuit = currentStartNode.astParent as? ShortCircuitOperator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to make the look-ahead in the EOG here instead of checking the astParent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CDG and ShortCircuitOperators

4 participants