-
Notifications
You must be signed in to change notification settings - Fork 88
Migrate concepts from custom classes to ontology-based implementation #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (40.90%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Logging concepts from custom classes to ontology-based implementation
|
@interruptedHandshake As discussed, the ontology needs to be updated. Mainly adding or updating properties for Logging, HTTP, and Database concepts/operations. There are also a few minor related changes. |
Logging concepts from custom classes to ontology-based implementation|
|
||
| public open class DatabaseConnect( | ||
| calls: List<String>?, | ||
| calls: List<Node>?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be potentially difficult to rename. But will check that
|
|
||
| public open class DatabaseOperation( | ||
| public val calls: List<String>?, | ||
| public val calls: List<Node>?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: Could be potentially difficult to rename. But will check that
| val parameters: List<Node>, | ||
| public val modify: Boolean?, | ||
| calls: List<String>?, | ||
| calls: List<Node>?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: Could be potentially difficult to rename. But will check that
|
@lshala For the other changes I can say thats do-able. Maybe some of the parameter names have to be adapted a bit, but not of a big deal. |
Uh oh!
There was an error while loading. Please reload this page.