Skip to content

Conversation

@lshala
Copy link
Contributor

@lshala lshala commented Jan 9, 2026

  • Migrated concept classes to ontology-based classes
  • Removed old Logging, HTTP, and Auth concepts/operations

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 40.90909% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.62%. Comparing base (baf8e16) to head (76ccf17).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/cpg/graph/concepts/auth/AuthenticationBuilder.kt 0.00% 29 Missing ⚠️
...isec/cpg/graph/concepts/http/HttpConceptBuilder.kt 0.00% 22 Missing ⚠️
...oncepts/logging/python/PythonLoggingConceptPass.kt 87.50% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (40.90%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
Files with missing lines Coverage Δ
...aisec/cpg/graph/concepts/logging/LoggingBuilder.kt 100.00% <100.00%> (ø)
...nhofer/aisec/cpg/graph/concepts/policy/Boundary.kt 85.71% <ø> (ø)
...oncepts/logging/python/PythonLoggingConceptPass.kt 89.77% <87.50%> (ø)
...isec/cpg/graph/concepts/http/HttpConceptBuilder.kt 0.00% <0.00%> (ø)
...c/cpg/graph/concepts/auth/AuthenticationBuilder.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lshala lshala changed the title Migrate logging concepts from custom classes to ontology-based implementation Migrate Logging concepts from custom classes to ontology-based implementation Jan 9, 2026
@lshala
Copy link
Contributor Author

lshala commented Jan 9, 2026

@interruptedHandshake As discussed, the ontology needs to be updated. Mainly adding or updating properties for Logging, HTTP, and Database concepts/operations. There are also a few minor related changes.

@lshala lshala marked this pull request as ready for review January 9, 2026 15:44
@lshala lshala requested a review from maximiliankaul as a code owner January 9, 2026 15:44
@lshala lshala marked this pull request as draft January 9, 2026 15:46
@lshala lshala marked this pull request as ready for review January 9, 2026 16:10
@lshala lshala added the publish-to-github-packages If added to a PR, builds from it will be published as a GitHub package label Jan 9, 2026
@lshala lshala marked this pull request as draft January 9, 2026 22:36
@lshala lshala changed the title Migrate Logging concepts from custom classes to ontology-based implementation Migrate concepts from custom classes to ontology-based implementation Jan 9, 2026

public open class DatabaseConnect(
calls: List<String>?,
calls: List<Node>?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be potentially difficult to rename. But will check that


public open class DatabaseOperation(
public val calls: List<String>?,
public val calls: List<Node>?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: Could be potentially difficult to rename. But will check that

val parameters: List<Node>,
public val modify: Boolean?,
calls: List<String>?,
calls: List<Node>?,
Copy link
Contributor

@interruptedHandshake interruptedHandshake Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: Could be potentially difficult to rename. But will check that

@interruptedHandshake
Copy link
Contributor

@lshala For the other changes I can say thats do-able. Maybe some of the parameter names have to be adapted a bit, but not of a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

publish-to-github-packages If added to a PR, builds from it will be published as a GitHub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants