Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ID of a QueryTree is based on the node it relates to, the QueryTree's value and the IDs of the children. This means that, if multiple QueryTrees relate to the same node and have equal children (e.g.
falseor no children at all), they all share the same ID. In the Codyze Web UI, there is no way to distinguish them and results may be displayed in a weird way (i.e., one of these nodes will be displayed multiple times, instead of displaying all of the nodes).I'm trying to make this a bit less likely by including the string representation into the ID as well. Are there any other fields that we can/should include here? If I remember correctly, using the parent node was somewhat problematic due to our logic suppressing results.