Skip to content

Conversation

@KuechA
Copy link
Contributor

@KuechA KuechA commented Jan 19, 2026

Currently, the ID of a QueryTree is based on the node it relates to, the QueryTree's value and the IDs of the children. This means that, if multiple QueryTrees relate to the same node and have equal children (e.g. false or no children at all), they all share the same ID. In the Codyze Web UI, there is no way to distinguish them and results may be displayed in a weird way (i.e., one of these nodes will be displayed multiple times, instead of displaying all of the nodes).

I'm trying to make this a bit less likely by including the string representation into the ID as well. Are there any other fields that we can/should include here? If I remember correctly, using the parent node was somewhat problematic due to our logic suppressing results.

@KuechA KuechA requested a review from oxisto as a code owner January 19, 2026 13:45
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.52%. Comparing base (977182a) to head (17f7df0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
.../kotlin/de/fraunhofer/aisec/cpg/query/QueryTree.kt 69.27% <100.00%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KuechA KuechA requested a review from konradweiss as a code owner January 20, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants