tests: Add end to end tests with bats #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
rumpelsepp
force-pushed
the
testing
branch
2 times, most recently
from
1169462
to
2f3ae11
Compare
rumpelsepp
force-pushed
the
testing
branch
2 times, most recently
from
1e46a6d
to
14264b0
Compare
rumpelsepp
force-pushed
the
testing
branch
11 times, most recently
from
3f867ea
to
70a8a49
Compare
Those are covered now by a bats testsuite in gallia.
Piping data to stdin of `hr` was broken due to a faulty check. This was discovered writing bats checks for `hr`.
peckto
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the CLI "tests" into
batstests. For now there is not much delta, since the gallia commands are just run as before. However, the information provided bybatsin case of errors is already superior and more helpul. See screenshots below.The next step would be checks for expected output of
gallia, e.g. artifacts or similar. I hope this will be helpul to get gallia 2.0 over the finish line. @fkglrThe tests are in the
.batsfiles and should be easy to understand. If a test function returns with an exit code!= 0then the stdout/stderr of all run commands are printed and an error is logged (see second screenshot)..batsis just a Bash script.Bats 1.8 is used from debian stable, so I consider this tool as universally available.
Injected a
return 1for demonstration purposes: