Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ECU.connect): move definition to UDSClient and call it as part of UDSClient.reconnect #575

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

emedav
Copy link
Contributor

@emedav emedav commented Aug 7, 2024

No description provided.

@rumpelsepp
Copy link
Member

I think this method is not used any more: https://github.com/search?q=repo%3AFraunhofer-AISEC%2Fgallia%20.connect()&type=code

We had this in a historic version IIRC. Is there code that should be in .connect()? If not, I would just remove this unused method instead.

@rumpelsepp rumpelsepp added this to the gallia 2.0 milestone Aug 12, 2024
@emedav
Copy link
Contributor Author

emedav commented Aug 16, 2024

I think this method is not used any more: https://github.com/search?q=repo%3AFraunhofer-AISEC%2Fgallia%20.connect()&type=code

We had this in a historic version IIRC. Is there code that should be in .connect()? If not, I would just remove this unused method instead.

It is not currently used by any code in this repository, but with the change I proposed it becomes a nice hook for vendor-specific setup code required in some of our proprietary plug-ins.

@rumpelsepp
Copy link
Member

I see. So, .connect() in those cases triggers the .connect() of the transport underneath, does it?

@rumpelsepp rumpelsepp merged commit 7c6b026 into master Aug 19, 2024
14 checks passed
@rumpelsepp rumpelsepp deleted the move-ecu-connect branch August 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants