Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect native fluid ads by app events on Android #7

Merged

Conversation

przemyslawzalewski
Copy link

Even for native/fluid ads, the Android ads library reports them as plain banner ads. This is preventing the layout of the ad properly as the 320_50_mb is a valid banner size. With this PR, the fluid/native ad is detected anytime the ad sends any custom ad event.

The issue is deep within the Google Ads library, affecting others as well, for example, sbugert/react-native-admob#206.

Zrzut ekranu 2022-03-2 o 19 33 00

@przemyslawzalewski przemyslawzalewski merged commit f678dbb into master Mar 4, 2022
@przemyslawzalewski przemyslawzalewski deleted the detect_native_fluid_ads_by_app_events_on_android branch March 4, 2022 14:41
@mikehardy
Copy link

Hi there 👋 - I'm part of a group that is also implementing ads in a different module - https://github.com/invertase/react-native-google-mobile-ads (reborn recently/finally from the official google firebase react-native repo @react-native-firebase/admob after firebase purged their AdMob APIs a couple years ago).

We have run into this fluid banner android thing as well and your repo was just mentioned here invertase/react-native-google-mobile-ads#130 - Honestly I had looked around at all react-native google ads repos I thought but did not see this one!

That said, I have two questions if you have the time to answer?

1- in your experience, is it really true that any event at all from the android underlying SDK for a banner ad means it is a fluid ad? That seems...risky to just assume it but you all have the experience clearly

2- would you be interested in joining forces with us so we have one repo with more maintainers? As a maintainer of a lot of repos myself, I always enjoy it more when there are more maintainers to spread the workload. Additionally, we have built-in UMP / consent form handling, support for hooks, and in my work with Invertase (the supporting company) I handle most of the day-to-day administration (like dependencies, CI, release automation, example app management, issue triage etc), but we have 4 active developers and a few active testers at the moment so it's a good crew. Here's a similar pitch I made to the only other native ads implementation I'm aware of in case you're interested - ammarahm-ed/react-native-admob-native-ads#274 - either way cheers! :-)

songyu2018 pushed a commit to zjkuang/OpenWrapInRN that referenced this pull request May 5, 2022
@djMax
Copy link

djMax commented May 7, 2022

I don't believe this PR actually solves this problem. I created a bare native app and added the banner, and it is cutoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants