Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CI with Github Actions #329

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

New CI with Github Actions #329

wants to merge 6 commits into from

Conversation

simonlegrand
Copy link
Contributor

Here is a first contribution to the new FreeFem CI.

5 different configurations of FreeFem are tested:

  • Minimal version
  • Sequential version (with all dependencies)
  • Full version OpenMPI
  • Full version MPICH
  • Full version MS-MPI

Each of these workflows contains jobs for Debug and Release and different combinations of platforms.

Currently, the build step doesn't work for the following configuration:

  • Sequential/Windows/Debug
  • Full Version MS-MPI/Debug
  • Full Version OpenMPI/MacOS-14/*

But most of the tests should fail because of the removal of the continue-on-error: true at the make check step (few tests fail for almost each config). It can be temporarily put back if you prefer.

At first, if you prefer to merge on a different branch, just add the branch name in the

on:
  push:
    branches:
      ..
      - <branch_name>

Finally, due to the particular development workflow (push to test), the commit history is particularly dirty and should probably be squashed before the merge. It can be retrieved here

Cheers,
Simon

@prj-
Copy link
Member

prj- commented Dec 20, 2024

Why do you need to install SuiteSparse explicitly when building PETSc? Can't you let PETSc install it? Also, there are a couple of parallel packages in the sequential installs (ParMmg, ParMETIS, to name a few).

@simonlegrand
Copy link
Contributor Author

Bien vu, I stupidly copy paste former tests. I'm not completely familiar with all the dependencies, can you confirm that I didn't leave anything uselss?

prj-
prj- reviewed Dec 21, 2024
View reviewed changes
@simonlegrand
Copy link
Contributor Author

Thanks ;)

@simonlegrand simonlegrand force-pushed the slegrand-actions branch 3 times, most recently from e100e87 to 6c11b37 Compare January 17, 2025 16:20
prj-
prj- reviewed Jan 17, 2025
View reviewed changes
@simonlegrand
Copy link
Contributor Author

Three previous comments fixed in 92027eb

@prj- prj- force-pushed the slegrand-actions branch 2 times, most recently from f27fbdd to 3a5c86b Compare January 30, 2025 15:27
@FreeFem FreeFem deleted a comment from sonarqubecloud bot Jan 30, 2025
@prj- prj- force-pushed the slegrand-actions branch 6 times, most recently from 93c41a2 to daba3d8 Compare February 4, 2025 17:03
@simonlegrand simonlegrand force-pushed the slegrand-actions branch 3 times, most recently from dc77ce3 to 089d568 Compare February 13, 2025 17:15
@simonlegrand simonlegrand force-pushed the slegrand-actions branch 5 times, most recently from d02ddc3 to 9f62c13 Compare February 26, 2025 13:16
@simonlegrand simonlegrand force-pushed the slegrand-actions branch 3 times, most recently from 791551e to 4835487 Compare March 7, 2025 15:33
@prj-
Copy link
Member

prj- commented Mar 9, 2025

Could you please try to squash commits together when applicable? It would be easier to review.

prj-
prj- reviewed Mar 9, 2025
View reviewed changes
prj-
prj- reviewed Mar 16, 2025
View reviewed changes
@prj-
Copy link
Member

prj- commented Mar 16, 2025

We are almost there, thank you for your work. Again, if you could squash as many commits together as possible, that would make it easier to review.

prj-
prj- reviewed Mar 25, 2025
View reviewed changes
Copy link
Member

@prj- prj- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just very minor comments, but LGTM otherwise.

simonlegrand and others added 6 commits March 25, 2025 14:17
@simonlegrand
Add Github actions workflows definitions and utils
3055e30 
Includes Simon Garnotel initial work, which detail is on the
feature-github-actions branch.

- Set proper Xcode versions and uninstall brew llvm.
- Direct use of LDFLAGS to pass linker options instead of CC and CXX.
- Use -ld_classic when necessary
- Add https://joliv.et to overcome ljll network problems
@simonlegrand
Add status badges
2df8480 
- Minimal and full MPICH on master are exposed in README.md
- Details about other versions are in .github/CI.md
@simonlegrand
Clean Jenkins related files
040a227
@simonlegrand
Fix tetgen depedencies (cylinder-3d) in examples
02877e7
@simonlegrand @prj-
Fix n_name_param for MeshS
016590a 
Update plugin/seq/iovtk.cpp

Co-authored-by: Pierre Jolivet <[email protected]>

Update plugin/seq/iovtk.cpp

Co-authored-by: Pierre Jolivet <[email protected]>
@simonlegrand
Fix timeout check on Linux
137810f
@prj-
Copy link
Member

prj- commented Mar 25, 2025

It looks like the job Windows Server 2022 with --enable-debug is constantly failing. Are you trying to debug it? If not, I don't think it's worth to put in the Actions.

@simonlegrand
Copy link
Contributor Author

Yes, we are waiting for a Windows VM prepared by the Inria IT to debug it interactively without the constraints of the Github Actions Runner (time limit, resources, ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prj- prj- prj- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonlegrand @prj-