Conversation
|
Why do you need to install SuiteSparse explicitly when building PETSc? Can't you let PETSc install it? Also, there are a couple of parallel packages in the sequential installs (ParMmg, ParMETIS, to name a few). |
|
Bien vu, I stupidly copy paste former tests. I'm not completely familiar with all the dependencies, can you confirm that I didn't leave anything uselss? |
|
Thanks ;) |
e100e87 to
6c11b37
Compare
6c11b37 to
69d7895
Compare
|
Three previous comments fixed in 92027eb |
3673fe6 to
8778ca9
Compare
f27fbdd to
3a5c86b
Compare
3a5c86b to
cc98caa
Compare
93c41a2 to
daba3d8
Compare
5b39537 to
a39ac9c
Compare
dc77ce3 to
089d568
Compare
d02ddc3 to
9f62c13
Compare
8085226 to
137810f
Compare
|
It looks like the job |
|
Yes, we are waiting for a Windows VM prepared by the Inria IT to debug it interactively without the constraints of the Github Actions Runner (time limit, resources, ...). |
52b9863 to
a812c3a
Compare
|
I commented the Windows/Debug tests combination in Sequential and Full version MS-MPI. We'll dig into the problem as soon we get access to the virtual machine. |
0accf4c to
4df1aec
Compare
4df1aec to
ed719e4
Compare
ed719e4 to
1d9830d
Compare
|
All good on my end (modulo the merge conflicts). |
d63e401 to
0c07cb2
Compare
|
Why do you need to update SuperLU in |
82563e3 to
0c07cb2
Compare
|
Sorry I pushed the wrong branch. The sequential version of FF, that uses 3rdparty SuperLU, failed to compile with gcc-15 (used by the Windows runner). Out of curiousity, I wanted to try more recent versions of SuperLU but it appears to fail for versions 6.0.1 and 7.0.1 as well, but for different reasons (see here). This is weird since PETSc uses the version 6.0.1and FF links ok against it, but I may have missed a flag or something. Anyway, I guess the best thing to do for now is to add the |
|
I would just disable SuperLU from the CI. |
Includes Simon Garnotel initial work, which detail is on the feature-github-actions branch. - Set proper Xcode versions and uninstall brew llvm. - Direct use of LDFLAGS to pass linker options instead of CC and CXX. - Use -ld_classic when necessary - Add https://joliv.et to overcome ljll network problems - Upload artifacts in case of failure
- Minimal and full MPICH on master are exposed in README.md - Details about other versions are in .github/CI.md
Update plugin/seq/iovtk.cpp Co-authored-by: Pierre Jolivet <prj-@users.noreply.github.com> Update plugin/seq/iovtk.cpp Co-authored-by: Pierre Jolivet <prj-@users.noreply.github.com>
0c07cb2 to
60b0a19
Compare
|
Sorry for the late reply. I also removed SCOTCH from the sequential version on Windows, it had the same issue as SuperLU. Also, I removed the explicit call to 3rd/getall to download all the dependencies, since make is calling it anyway if the dependencies are not disabled (with --disable-). |
|
If everything pass, I merge, OK for you? |
|
yes , Ok pour moi.
… Le 6 juin 2025 à 16:40, Pierre Jolivet ***@***.***> a écrit :
prj-
left a comment
(FreeFem/FreeFem-sources#329)
<#329 (comment)>
If everything pass, I merge, OK for you?
—
Reply to this email directly, view it on GitHub <#329 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLPNDCTJSPEPYR5NFNSL233CGR7DAVCNFSM6AAAAABT5NPYV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNBZGQ3TKNRYGU>.
You are receiving this because you are subscribed to this thread.
|
Here is a first contribution to the new FreeFem CI.
5 different configurations of FreeFem are tested:
Each of these workflows contains jobs for Debug and Release and different combinations of platforms.
Currently, the build step doesn't work for the following configuration:
But most of the tests should fail because of the removal of the
continue-on-error: trueat themake checkstep (few tests fail for almost each config). It can be temporarily put back if you prefer.At first, if you prefer to merge on a different branch, just add the branch name in the
Finally, due to the particular development workflow (push to test), the commit history is particularly dirty and should probably be squashed before the merge. It can be retrieved here
Cheers,
Simon