Skip to content

New CI with Github Actions#329

Merged
prj- merged 6 commits intoFreeFem:developfrom
simonlegrand:slegrand-actions
Jun 6, 2025
Merged

New CI with Github Actions#329
prj- merged 6 commits intoFreeFem:developfrom
simonlegrand:slegrand-actions

Conversation

@simonlegrand
Copy link
Contributor

Here is a first contribution to the new FreeFem CI.

5 different configurations of FreeFem are tested:

  • Minimal version
  • Sequential version (with all dependencies)
  • Full version OpenMPI
  • Full version MPICH
  • Full version MS-MPI

Each of these workflows contains jobs for Debug and Release and different combinations of platforms.

Currently, the build step doesn't work for the following configuration:

  • Sequential/Windows/Debug
  • Full Version MS-MPI/Debug
  • Full Version OpenMPI/MacOS-14/*

But most of the tests should fail because of the removal of the continue-on-error: true at the make check step (few tests fail for almost each config). It can be temporarily put back if you prefer.

At first, if you prefer to merge on a different branch, just add the branch name in the

on:
  push:
    branches:
      ..
      - <branch_name>

Finally, due to the particular development workflow (push to test), the commit history is particularly dirty and should probably be squashed before the merge. It can be retrieved here

Cheers,
Simon

@prj-
Copy link
Member

prj- commented Dec 20, 2024

Why do you need to install SuiteSparse explicitly when building PETSc? Can't you let PETSc install it? Also, there are a couple of parallel packages in the sequential installs (ParMmg, ParMETIS, to name a few).

@simonlegrand
Copy link
Contributor Author

Bien vu, I stupidly copy paste former tests. I'm not completely familiar with all the dependencies, can you confirm that I didn't leave anything uselss?

@simonlegrand
Copy link
Contributor Author

Thanks ;)

@simonlegrand simonlegrand force-pushed the slegrand-actions branch 3 times, most recently from e100e87 to 6c11b37 Compare January 17, 2025 16:20
@simonlegrand
Copy link
Contributor Author

Three previous comments fixed in 92027eb

@prj- prj- force-pushed the slegrand-actions branch 2 times, most recently from f27fbdd to 3a5c86b Compare January 30, 2025 15:27
@FreeFem FreeFem deleted a comment from sonarqubecloud bot Jan 30, 2025
@prj- prj- force-pushed the slegrand-actions branch 6 times, most recently from 93c41a2 to daba3d8 Compare February 4, 2025 17:03
@simonlegrand simonlegrand force-pushed the slegrand-actions branch 3 times, most recently from dc77ce3 to 089d568 Compare February 13, 2025 17:15
@simonlegrand simonlegrand force-pushed the slegrand-actions branch 5 times, most recently from d02ddc3 to 9f62c13 Compare February 26, 2025 13:16
@prj-
Copy link
Member

prj- commented Mar 25, 2025

It looks like the job Windows Server 2022 with --enable-debug is constantly failing. Are you trying to debug it? If not, I don't think it's worth to put in the Actions.

@simonlegrand
Copy link
Contributor Author

Yes, we are waiting for a Windows VM prepared by the Inria IT to debug it interactively without the constraints of the Github Actions Runner (time limit, resources, ...).

@simonlegrand simonlegrand force-pushed the slegrand-actions branch 2 times, most recently from 52b9863 to a812c3a Compare March 31, 2025 09:26
@simonlegrand
Copy link
Contributor Author

I commented the Windows/Debug tests combination in Sequential and Full version MS-MPI. We'll dig into the problem as soon we get access to the virtual machine.

@simonlegrand simonlegrand force-pushed the slegrand-actions branch 3 times, most recently from 0accf4c to 4df1aec Compare April 2, 2025 10:16
@prj-
Copy link
Member

prj- commented Apr 29, 2025

All good on my end (modulo the merge conflicts).

@simonlegrand simonlegrand force-pushed the slegrand-actions branch 2 times, most recently from d63e401 to 0c07cb2 Compare May 2, 2025 09:36
@prj-
Copy link
Member

prj- commented May 5, 2025

Why do you need to update SuperLU in 3rdparty/getall? The last version is already downloaded by make petsc-slepc, there is no real need to update the legacy getall, is there?

@simonlegrand
Copy link
Contributor Author

Sorry I pushed the wrong branch. The sequential version of FF, that uses 3rdparty SuperLU, failed to compile with gcc-15 (used by the Windows runner). Out of curiousity, I wanted to try more recent versions of SuperLU but it appears to fail for versions 6.0.1 and 7.0.1 as well, but for different reasons (see here). This is weird since PETSc uses the version 6.0.1and FF links ok against it, but I may have missed a flag or something.

Anyway, I guess the best thing to do for now is to add the -std=gnu17 if gcc-15 is detected. What do you think?

@prj-
Copy link
Member

prj- commented May 7, 2025

I would just disable SuperLU from the CI.

simonlegrand and others added 6 commits June 6, 2025 16:11
Includes Simon Garnotel initial work, which detail is on the
feature-github-actions branch.

- Set proper Xcode versions and uninstall brew llvm.
- Direct use of LDFLAGS to pass linker options instead of CC and CXX.
- Use -ld_classic when necessary
- Add https://joliv.et to overcome ljll network problems
- Upload artifacts in case of failure
- Minimal and full MPICH on master are exposed in README.md
- Details about other versions are in .github/CI.md
Update plugin/seq/iovtk.cpp

Co-authored-by: Pierre Jolivet <prj-@users.noreply.github.com>

Update plugin/seq/iovtk.cpp

Co-authored-by: Pierre Jolivet <prj-@users.noreply.github.com>
@simonlegrand
Copy link
Contributor Author

Sorry for the late reply. I also removed SCOTCH from the sequential version on Windows, it had the same issue as SuperLU. Also, I removed the explicit call to 3rd/getall to download all the dependencies, since make is calling it anyway if the dependencies are not disabled (with --disable-).

@prj-
Copy link
Member

prj- commented Jun 6, 2025

If everything pass, I merge, OK for you?

@frederichecht
Copy link
Contributor

frederichecht commented Jun 6, 2025 via email

@prj- prj- merged commit f24f770 into FreeFem:develop Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants