fix[IAR/RL78 Port] Compilation fails on portasm.s file #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indentation on ASM macro is not authorized by IAR compiler
|
kar-rahul-aws
approved these changes
May 12, 2025
|
Hi @5iBri We reproduced the issue on :
and confirmed the patch fixes the compilation issue. |
aggarg
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation failure on portasm.s file for IAR/RL78 port
Description
Compilation of the ASM file fails when using IAR version 5.10.3. See issue #1277 for more details.
To resolve this, the indentation of ASM macros in the portmacro.h file was adjusted. The IAR assembler only accepts ASM macro definitions that begin at the start of the line; indenting the macro name causes a compilation error.
This behavior was observed with IAR 5.10.3. Earlier versions have not been tested.
Test Steps
See issue #1277
Checklist:
Related Issue
Bug #1277
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.