Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated config.py more platform independent (Win32) #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

phreed
Copy link

@phreed phreed commented Nov 30, 2023

Issues to discuss:

Use of platformdirs

platformdirs makes some decisions that differ from those in the config.py.
https://platformdirs.readthedocs.io/en/latest/

Use of sysconfig

sysconfig can be used to identify the site-packages (or equivalent).
The use of MAIN_PATH = Path(sysconfig.get_path('purelib')) may be more reliable;
than, searching based on knowing the location of __file__.

Using python Paths rather than strings

The place where this is most likely is config.py.
Are there other source files that should be considered?

@phreed phreed changed the title Updated config.py more platform independent Updated config.py more platform independent (Win32) Nov 30, 2023
@brothercorvo brothercorvo self-assigned this Nov 30, 2023
@brothercorvo
Copy link
Contributor

we need to extensive test this. In general we want to host all user configurations in the YAML file.
see the priorty of configuration
image

@phreed
Copy link
Author

phreed commented Nov 30, 2023

we need to extensive test this. In general we want to host all user configurations in the YAML file. see the priorty of configuration

Yes indeed.
I see FTSConfig.yaml as used in development.
I see in FTS Docs the two files described being edited to configure FTS are <site-packages>/FreeTAKServer-UI/config.py and <site-packages>/FreeTAKServer/controllers/configuration/MainConfig.py.

Those files are:

Is it appropriate for these documents to recommend modifying config.py?

@brothercorvo
Copy link
Contributor

@naman108 please review this and see if we can approve

@brothercorvo
Copy link
Contributor

@naman108 ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants