-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve accessibility of FreeTube input elements #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FreeTubeBot
merged 23 commits into
FreeTubeApp:development
from
ChunkyProgrammer:accessibility-inputs
Dec 11, 2022
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0841bf3
improve accessibility of FreeTube input elements
ChunkyProgrammer 7ff59cb
make focus visible for prompt
ChunkyProgrammer 2eb9b61
add close button to ft-prompt
ChunkyProgrammer 3d4d4b4
Update src/renderer/components/ft-icon-button/ft-icon-button.vue
ChunkyProgrammer 669839e
make suggested changes
ChunkyProgrammer 1d44b4e
move eslint plugin to devdepedencies
ChunkyProgrammer 0e21f2c
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 52dbdd5
dont hide ft-prompt on focus out
ChunkyProgrammer ecd22ed
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 0628d78
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 55ad447
add aria-describeby
ChunkyProgrammer 4062537
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 413796e
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 3251b81
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 3ae3b7c
update eslint-plugin-vuejs-accessibility
ChunkyProgrammer 3d2a940
Update yarn.lock
ChunkyProgrammer 5199ff5
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer b699e9c
Update yarn.lock
ChunkyProgrammer d06b2ba
Fix lint issues
ChunkyProgrammer 935903b
only escape whitespace in ids
ChunkyProgrammer 9383022
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 9b40faf
Merge branch 'development' into accessibility-inputs
ChunkyProgrammer 5611cc5
use computed properties
ChunkyProgrammer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| <template> | ||
| <button | ||
| :id="id.length > 0 ? id : null" | ||
| class="btn ripple" | ||
| :style="{ | ||
| color: textColor, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.