Skip to content

Fix filename tooltip not showing under screenshot in player settings #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

MarmadileManteater
Copy link
Contributor

Fix filename tooltip not showing under screenshot settings

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Description

The tooltip under the screenshot heading in player settings is hidden on small displays because it is actually stuck in the top corner of the page. This causes overflow as well because the tooltip is not contained within the player settings section. This PR addresses this by adding position: relative to .screenshotFilenamePatternTitle and adding margins to the tooltip to put it in a visually acceptable place as to prevent overflow.

Screenshots

before after
2025-04-06-134813_hyprshot 2025-04-06-134802_hyprshot

Testing

  1. Open up player settings
  2. Reduce the window width to below 680px
  3. Ensure the tooltip icon remains visible and there is no horizontal scrollbar on the page

Desktop

  • OS: Fedora w/ Hyprland
  • OS Version: 41
  • FreeTube version: a058ccd

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 6, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 6, 2025 17:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/renderer/components/player-settings/player-settings.css: Language not supported

@PikachuEXE
Copy link
Collaborator

Probably should try to see if the existing style can be fixed first
image

@PikachuEXE
Copy link
Collaborator

Alternative:
src/renderer/components/player-settings/player-settings.vue
image
src/renderer/components/FtSettingsSection/FtSettingsSection.scss
image

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 20, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants