Skip to content

Remove Export Playlists For Older FreeTube Versions #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FreeTubeBot merged 10 commits into from
Aug 9, 2025
Merged

Remove Export Playlists For Older FreeTube Versions #7195

FreeTubeBot merged 10 commits into from
Aug 9, 2025

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 13, 2025

Remove Export Playlists For Older FreeTube Versions

Pull Request Type

  • Other - Cleanup

Related issue

Part of previous changelogs

The setting Export Playlists For Older FreeTube Versions will be deprecated in v0.24.0

Description

Removed everything related to the Export Playlists For Older FreeTube Versions setting

Testing

  • Check that normal export functionality still works
  • Check that all references to this setting has been removed

Desktop

  • OS: Ubuntu
  • OS Version: 24.04 LTS
  • FreeTube version: 21161ac

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc marked this pull request as ready for review April 13, 2025 20:53
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 13, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 13, 2025 20:53
@PikachuEXE
Copy link
Collaborator

PikachuEXE commented Apr 13, 2025 •
edited
Loading

deprecate means going to be removed, not removing it entirely...
If the original plan is to remove in 0.24, the release note should have be written as remove

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 14, 2025 •
edited
Loading

If the original plan is to remove in 0.24, the release note should have be written as remove

This is our original plan. I just wrote it the wrong way in the changelog. Imo its not a big deal as i think that we have given users enough time and im pretty sure that no one is using versions of FT where the playback is broken

@PikachuEXE
Copy link
Collaborator

PikachuEXE commented Apr 14, 2025

0.24 change log should say remove
Anyway this should be merged almost right before 0.24 release not approving yet

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 15, 2025

I noticed that there wasnt any css removed. Is there no css for this?

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: WIP and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE
PikachuEXE reviewed Apr 23, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE
PikachuEXE previously approved these changes Jul 29, 2025
View reviewed changes
@PikachuEXE PikachuEXE added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP labels Jul 29, 2025
absidue
absidue reviewed Aug 1, 2025
View reviewed changes
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the FtToggleSwitch import to fix the linter warning.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 1, 2025

@absidue done!

@FreeTubeBot FreeTubeBot merged commit c50f00a into FreeTubeApp:development Aug 9, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 9, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the rem-older-playlist-export branch August 9, 2025 02:39
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 11, 2025
@PikachuEXE
Merge branch 'development' into sabr
eb1f1ec 
* development:
  Translated using Weblate (Serbian)
  Fix selecting a new quick bookmark playlist (FreeTubeApp#7803)
  Migrate DistractionSettings to the composition API (FreeTubeApp#7807)
  Use Array#find directly when parsing the chapters (FreeTubeApp#7808)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Croatian)
  change iina name to IINA (FreeTubeApp#7773)
  Remove `Export Playlists For Older FreeTube Versions` (FreeTubeApp#7195)
  Enhancement: Add fast forward and rewind pop up to video player (FreeTubeApp#7729)
  Fix "more" button from sidenav not closing (FreeTubeApp#7725)
  Fix handleSyncSubscriptionCache using the SYNC_PLAYLISTS IPC channel (FreeTubeApp#7756)
  Change Close button color to white (FreeTubeApp#7752)
  Migrate PlayerSettings to the composition API (FreeTubeApp#7766)
  Bump package version from 0.23.5 to 0.23.6 (FreeTubeApp#7794)
  Add shorts player parameters to help with 403s (FreeTubeApp#7763)
  Translated using Weblate (Norwegian Bokmål)
  Bump the stylelint group with 2 updates (FreeTubeApp#7779)
  Bump tmp from 0.2.1 to 0.2.4 (FreeTubeApp#7790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@kommunarr kommunarr kommunarr approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @kommunarr @FreeTubeBot