Skip to content

Downgrade electron 36 > 35, Fix video DASH playback #7421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Downgrade electron 36 > 35, Fix video DASH playback #7421

wants to merge 2 commits into from

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented May 16, 2025 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Caused by upgrade in #7403

Description

See errors in screenshot (and other webm related errors in https://github.com/shaka-project/shaka-player/blob/v4.14.11/lib/dash/webm_segment_index_parser.js)

I've tried using shaka-player 4.14.9-12 in electron 36.2.1, not working

Screenshots

Screenshot 2025-05-16 at 17 41 57

Testing

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

No idea which change is causing this in 36 https://releases.electronjs.org/release/v36.0.0

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels May 16, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 16, 2025 10:04
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

I dont think we should downgrade intermediately. Its best to check what the root cause is and fix it otherwise we will be stuck on v35.x.x forever

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels May 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PikachuEXE PikachuEXE force-pushed the fix/electron-video-playback-error branch from 6b7e9f1 to 8ee5d7d Compare May 20, 2025 00:18
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE PikachuEXE mentioned this pull request May 20, 2025
Closed
@PikachuEXE
Copy link
Collaborator Author

Reported issue in shaka-project/shaka-player#8616

@PikachuEXE
Copy link
Collaborator Author

As I said in linked issue the issue seems fixed in Chrome 137
According to Electron release timeline Chrome 137/138 = 37.x would only be released in 2025-Jun-24 (~1 month from now
I will keep this open until then (and any major release should be made after that

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE PikachuEXE force-pushed the fix/electron-video-playback-error branch from bef34b8 to 69b0ef2 Compare June 2, 2025 01:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE PikachuEXE mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue Awaiting requested review from absidue

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@kommunarr kommunarr Awaiting requested review from kommunarr

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc