Skip to content

add search filter reset button #7531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

add search filter reset button #7531

wants to merge 4 commits into from

Conversation

ozrendev
Copy link
Contributor

@ozrendev ozrendev commented Jun 7, 2025 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #7396

Description

Add button that clears active search filters

Screenshots

Before
2025-06-07_23-27-30

After
2025-06-07_23-24-27

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 7, 2025 21:28
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 7, 2025
PikachuEXE
PikachuEXE requested changes Jun 8, 2025
View reviewed changes
src/renderer/components/FtSearchFilters/FtSearchFilters.vue Outdated
@@ -50,6 +50,12 @@
/>
</FtFlexBox>
<div class="searchFilterCloseButtonContainer">
<FtButton
:label="$t('Clear filters')"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need an entry in static/locales/en-US.yaml so people can translate

Suggested change
:label="$t('Clear filters')"
:label="$t('Search Filters.Clear Filters')"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response, have committed those changes

auto-merge was automatically disabled June 8, 2025 07:10

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 8, 2025 07:10
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc requested changes Jun 8, 2025
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I looks like that the close and clear filters button use different kinds of red
  • Change secondary theme to Dracula green and see that words in clear filters label is white. See that the words within the buttons of the Data settings are black

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jun 8, 2025
@ozrendev
Copy link
Contributor Author

ozrendev commented Jun 8, 2025

  • I looks like that the close and clear filters button use different kinds of red

    • Change secondary theme to Dracula green and see that words in clear filters label is green. See that the words within the buttons of the Data settings are black

The clear filters button is using the secondary color var as I thought this would be less confusing. I can change it to the primary color though or whichever is suitable?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Please read my comment again. I do not have anything against the secondary color theme. I have an issue with the text within it

auto-merge was automatically disabled June 8, 2025 19:43

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 8, 2025 19:43
@ozrendev
Copy link
Contributor Author

ozrendev commented Jun 8, 2025 •
edited
Loading

Ah okay I got it now, should be fixed

2025-06-08_22-36-47

@PikachuEXE
Copy link
Collaborator

I think you misunderstood
Expected: (See button at bottom right with black text
image

New button:
image

PikachuEXE
PikachuEXE reviewed Jun 9, 2025
View reviewed changes
static/locales/en-US.yaml Outdated
@@ -118,6 +118,7 @@ Search Filters:
Fetching results. Please wait: Fetching results. Please wait
Fetch more results: Fetch more results
There are no more results for this search: There are no more results for this search
Clear Filters: Clear filters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the places use capitalized words
e.g. settings page
image

Suggested change
Clear Filters: Clear filters
Clear Filters: Clear Filters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely misunderstood, this should follow expected behavior. I left the close button as-is from before

2025-06-09_09-04-42

auto-merge was automatically disabled June 9, 2025 07:06

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 9, 2025 07:06
@PikachuEXE PikachuEXE added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jun 9, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Probably very out of scope: I need someone else to verify because i dont know if its my panel put if my secondary color theme is set to Red the Close button got a different shade of Red then the Clear Filters button

@PikachuEXE
Copy link
Collaborator

Dunno what you are talking about
image

Using IPS panel

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Ok disregard what i said. Ty for testing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Search Filters Reset Button
3 participants
@ozrendev @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE