Implement types from units.ts & types.ts
#2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a literal union of all the units in `units.ts`
rename `player.summon` variables for clarity type the `obj` variable of creature constructor
prevents entire mock of `obj` now that it is typed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Great! Looking forward to trying it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional changes related to implementing the mentioned types:
player.tssummonmethod for clarity. Also typed the arguments.getScore.creature.tsobjargument of the constructor.objare defined.Tests for
creature.ts@ts-ignorecomments to prevent mocking the entireobjnow that it is typed.Types
UnitSize&UnitDisplayInfo.Movementdefinition.