HexGrid, Hex, pathfinding.ts refactor

[andretchen0]

This is largely clean up refactoring of a few files connected to HexGrid done in the course of reading through the files.

Note

One possibly controversial thing I wanted to point out is that I deprecated a lot of "shortcut" methods in HexGrid.

Those methods appeared to have been written before allhexes was added to HexGrid. As a result of adding allhexes, the shortcut method calls can each be replaced with a single line. That means less code and less indirection in a module that's already pretty busy. So, a good thing in my estimation.

It also deprecates forEachHex. Using allhexes allows all functional JS array methods. There's not a compelling reason to keep both approaches, and allhexes is much more flexible.

To compare:

forEach

• allhexes: hexGrid.allhexes.forEach(hex => doSomething(hex))
• forEachHex: hexGrid.forEachHex(hex => doSomething(hex))

filter

• allhexes: hexGrid.allhexes.filter(hex => isSomething(hex))
• forEachHex: no equivalent

map

• allhexes: hexGrid.allhexes.map(hex => transform(hex))
• forEachHex: no equivalent

... etc.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	Jul 31, 2023 10:36pm

[ghost]

👇 Click on the image for a new way to code review

Legend