refactor: adjacent hexes, remove clockwise argument, closes #2470 #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andretchen0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, this closes an 8-year-old TODO. As mentioned, the single caller using the
clockwiseargument doesn't make much sense in the context of a game with players facing opposing direction. So the clockwise argument was removed.That's my take, admittedly. Feel free to comment/disagree, as always.
Otherwise, the function eliminates reliance on the stateful
Hexclass. It still requires a bit of state to determine what's in- and out-of-bounds.HexGridholds that information, but it previously required a Demeter violation to access – reading intolengthof some arrays. That's been added instead as a method asHexGrid.isInBounds.Meta
This uses elements included in this PR. As it's a separate issue, I've open this as a separate PR.