Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fullscreen.js -> fullscreen.ts #2475

Merged
merged 3 commits into from
Aug 8, 2023
Merged

refactor: fullscreen.js -> fullscreen.ts #2475

merged 3 commits into from
Aug 8, 2023

Conversation

andretchen0
Copy link
Contributor

This converts fullscreen.js to fullscreen.ts. It also:

  • removes jQuery
  • (hopefully) clarifies some member, argument, function names
  • inlines some short functions
  • adds a JSDoc for the remaining private function

@vercel
Copy link

vercel bot commented Aug 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Aug 7, 2023 7:40pm

@ghost
Copy link

ghost commented Aug 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@andretchen0 andretchen0 marked this pull request as ready for review August 7, 2023 19:55
@DreadKnight
Copy link
Member

Nice! When testing this one out I've found another bug, issue is here -> #2479

@DreadKnight DreadKnight merged commit d7801cb into FreezingMoon:master Aug 8, 2023
3 checks passed
@andretchen0 andretchen0 deleted the fullscreen branch August 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andretchen0 @DreadKnight