Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: showcase branding in coordinate view [#2248] #2496

Merged
merged 4 commits into from
Oct 3, 2023
Merged

feat: showcase branding in coordinate view [#2248] #2496

merged 4 commits into from
Oct 3, 2023

Conversation

cesardlinx
Copy link
Contributor

I added the functionality of displaying the project logo in the background when hovering over the round marker or holding shift in order to trigger the hexagon coordinate view as you can see in the gif below. It shows up with a smooth transition as requested in the issue

ancient_beast

Closes #2248

My wallet address is 0xb2717FC8dFcc42A75E06A38aa273C0b9F4Cba848

@vercel
Copy link

vercel bot commented Oct 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Oct 2, 2023 4:26pm

@ghost
Copy link

ghost commented Oct 1, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DreadKnight
Copy link
Member

DreadKnight commented Oct 1, 2023 •
edited
Loading

@cesardlinx Heya! The "top" as em is bad, if you make the screen smaller you'll see why. It should use px and be a little bit under the unit queue avatars.

@DreadKnight DreadKnight marked this pull request as draft October 1, 2023 23:51
@cesardlinx
Copy link
Contributor Author

cesardlinx commented Oct 2, 2023 •
edited
Loading

@DreadKnight I see what you mean, please give it a look now. This is how it is looking. I changed it to px and I moved the brand a little bit under the queue as suggested.

ezgif com-optimize (1)

Let me know what do you think

@cesardlinx
Showcase branding in coordinate view (FreezingMoon#2248)
1e7ff57 
Hovering over the round marker or holding shift in order to trigger
the hexagon coordinate view the project text logo gets displayed in
the background, the 1/3 top part of the combat location, which
doesn't have the hexagon grid.

Closes FreezingMoon#2248
@cesardlinx
Use pixels instead of em to position brand
ea290bb
@DreadKnight
Copy link
Member

@cesardlinx Did more testing, some issues:

  1. Left side of the UI shouldn't be pushed down.
  2. Logo should also scale down as well with game.
    The idea is to not have logo ever overlap hexagons.
    I've been scaling game diagonally unlike your testing.

@cesardlinx
Copy link
Contributor Author

@DreadKnight Got it! lol I didn't noticed the left side sorry. I fixed all the mentioned issues. Give it a look, let me know what do you think

@cesardlinx
Copy link
Contributor Author

@DreadKnight Hey! Sorry I couldn't share the gif previously of how it looks but here it is

ancient_beast_brand6

@DreadKnight DreadKnight marked this pull request as ready for review October 3, 2023 00:17
@DreadKnight DreadKnight merged commit e67631a into FreezingMoon:master Oct 3, 2023
5 checks passed
@DreadKnight
Copy link
Member

@cesardlinx Alright, looks pretty ok now. No worries, gifs are always nice, but fully optional.
Merged and sent bounty 🪙

@cesardlinx
Copy link
Contributor Author

Cool! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

showcase branding in coordinate view [bounty: 4 XTR]
2 participants
@cesardlinx @DreadKnight