Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue resolved: basic attack icon not clickable #2515

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

Akashay-Anand
Copy link
Contributor

Issue Description:

  • Unit basic attacks (second ability icon) are no longer usable from left side icon, since the icon is not clickable even if the ability is usable. Workarounds like using hotkeys (W) or mouse wheel work just fine. Hovering the icon itself is also quite
    problematic, not showing a tooltip as well, which would have been helpful as it indicates the corresponding ability hotkey.

Findings

  • Initially, The Problem seems to be with Buttons logic... So I tried to find it in the code base. But, didn't get much to consider.
  • So After thoroughly analyzing UI on multiple screen sizes, found that the affected area is also changing with the screen and it is not related to any specific button.
  • Found that the Brandlogo is always been render above the leftpanel

Conclusion

  • The brand logo is always been rendered above the affected area. As this logo is hidden been rendered above the button, we can't click on the buttons that are covered by it.


Visual description


  • brand logo which has a div wrapper and hidden property attached to it
    pr 02

  • this div is been rendered above the Leftpanel and covers the entire width of the screen which doesn't seem to have any use-case... and also creates this issue
pr 00

  • To resolve this I adjusted the div size in a way that it still holds its initial position
  • I have tested this modification with multiple screen sizes and it's working properly.
css change 01


This fixes issue #2506

My wallet address is 0x44f6226bc89c4cb9D00F7c8E06c9d31Fa7D8B634

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Oct 20, 2023 8:36pm

@ghost
Copy link

ghost commented Oct 20, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DreadKnight DreadKnight merged commit 681d1a0 into FreezingMoon:master Oct 21, 2023
2 checks passed
@DreadKnight
Copy link
Member

@Akashay-Anand Well done, does the job. Bounty sent 🪙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants