Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-2542] Whip move interaction with plasma fielded dark priest #2625

Conversation

Changh341
Copy link
Contributor

This fixes issue #2542

My wallet address is 0x959E79438e522308587C3687d06bC3A467820119

Issue summary
Rework Headless' whip move to prevent enemy dark priest to be moved when plasma field is up and deal counter damage to headless if upgraded field. Ability should still work on friendies.

Actions taken
I added a new logical condition to whip move in headless.ts checking for enemy plasma fielded dark priest which prevents the movement and added a point of damage for the ability to trigger shielded and counter.

Preview
Recording 2024-09-24 at 14 07 54

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Sep 25, 2024 3:58am

@Changh341
Copy link
Contributor Author

I am not quite sure how to test if the conditional works on a XatteR shield proc.
But I wanted to push what I have so far and get some feedback if this is an acceptable solution

@DreadKnight
Copy link
Member

DreadKnight commented Sep 24, 2024

I am not quite sure how to test if the conditional works on a XatteR shield proc. But I wanted to push what I have so far and get some feedback if this is an acceptable solution

@Changh341 From what I can see in the gif, it's all good. Anyway, gonna test it in a bit. XatteR will eventually be implemented as an optional alternative to the free Plasma for online multiplayer matches as it will be a way to validate the legibility of moves, so a secure match will cost a little bit of XatteR, that way we can scale online multiplayer big time without stressing out regarding server costs and also decentralize things, by having players farm some XatteR by verifying moves; that's the plan at least. Online multiplayer matches using Plasma will be pure p2p and more prone to cheating.

@DreadKnight
Copy link
Member

Tested this a bit, seems to works well. Good job! Merging right away. Bounty sent with bonus -> https://www.mintme.com/explorer/tx/0x1a5f7baeb02f6b61246292590eaa98d32d5bc647da206311f757f90bc4899820 🪙

@DreadKnight DreadKnight linked an issue Sep 25, 2024 that may be closed by this pull request
@DreadKnight DreadKnight merged commit 53d0125 into FreezingMoon:master Sep 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whip Move ability vs Dark Priest [bounty: 11 XTR]
2 participants