Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creature vignette next turn status text #2643

Merged

Conversation

MilosDj21
Copy link
Contributor

This fixes issue #1049
If I understood comments in the related issue, this should solve it.
It replaces status text of units in the next round queue with the word Queued

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Nov 2, 2024 7:55am

@DreadKnight
Copy link
Member

@MilosDj21 I've tested it and doesn't cut it, though I appreciate the effort 👏🏻
I'll consider rewording the issue soon to be way more clear about purpose.
Feel free to poke at other less confusing issues meanwhile, plenty of them.

@DreadKnight
Copy link
Member

The idea is that status effects that only last one round should only be indicated in the queue in that specific round only.

@DreadKnight DreadKnight reopened this Oct 29, 2024
@MilosDj21
Copy link
Contributor Author

Oh, I see now what you mean. It's different than it was explained in the comments of the issue 😁
I'll see if I can manage to make it work the way you explained now

@DreadKnight
Copy link
Member

@MilosDj21 Hmm, I haven't read the comments recently, just the initial post. Anyway, looking forward to the updates 🐻

@MilosDj21
Copy link
Contributor Author

@DreadKnight I made improvements based on your feedback, please check if it works now as it should

@DreadKnight
Copy link
Member

@DreadKnight I made improvements based on your feedback, please check if it works now as it should

@MilosDj21 Works properly now as far as I can tell. Well done! And because of that "Queue" text shown straight up, maybe more people will easily figure that the UI part at the top is actually an unit queue 🐻

@DreadKnight DreadKnight merged commit 41eb015 into FreezingMoon:master Nov 2, 2024
6 checks passed
@MilosDj21 MilosDj21 deleted the fix-next-round-unit-status branch November 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants