-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace H160 in config and cli options of relayer by Bytes20 #1951
Closed
AurelienFT
wants to merge
15
commits into
FuelLabs:master
from
AurelienFT:use_bytes20_relayer_config
Closed
Replace H160 in config and cli options of relayer by Bytes20 #1951
AurelienFT
wants to merge
15
commits into
FuelLabs:master
from
AurelienFT:use_bytes20_relayer_config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el-core into use_bytes20_relayer_config
Voxelot
reviewed
Jun 11, 2024
…el-core into use_bytes20_relayer_config
…el-core into use_bytes20_relayer_config
5 tasks
xgreenx
added a commit
that referenced
this pull request
Aug 27, 2024
## Linked Issues/PRs #469 ## Description Replace H160 in config and cli options of relayer by Bytes20. This might cause a bit of performance impact as it's needed to transform them to `H160` to interact with `ethers_core` dependency. (This PR follows #1951) ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests - [x] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself - [x] I have created follow-up issues caused by this PR and linked them here --------- Co-authored-by: green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#469
Replace H160 in config and cli options of relayer by Bytes20. This might cause a bit of performance impact as it's needed to transform them to
H160
to interact withethers_core
dependency.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]