Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace H160 in config and cli options of relayer by Bytes20 #1951

Closed

Conversation

AurelienFT
Copy link
Contributor

#469

Replace H160 in config and cli options of relayer by Bytes20. This might cause a bit of performance impact as it's needed to transform them to H160 to interact with ethers_core dependency.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

CHANGELOG.md Outdated Show resolved Hide resolved
@AurelienFT AurelienFT closed this Aug 20, 2024
xgreenx added a commit that referenced this pull request Aug 27, 2024
## Linked Issues/PRs
#469

## Description

Replace H160 in config and cli options of relayer by Bytes20. This might
cause a bit of performance impact as it's needed to transform them to
`H160` to interact with `ethers_core` dependency.

(This PR follows #1951)

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here

---------

Co-authored-by: green <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants