Return reason of why proof cant be generated (api change) #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_of_why_proof_cant_be_generated_api_change
rafal-ch
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
xgreenx
approved these changes
Nov 13, 2024
MitchTurner
approved these changes
Nov 14, 2024
…nerated_api_change
…nerated_api_change
rafal-ch
deleted the
1394_return_reason_of_why_proof_cant_be_generated_api_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Additional changes related to #1394
Closes: #2367
Description
Initially we wanted these changes, but eventually decided to revert them from the original PR, because even though they are not considered strictly breaking, they change the API.
Checklist
Before requesting review