Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace task run() return result with custom enum #2429

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Replace task run() return result with custom enum #2429

wants to merge 20 commits into from

Commits on Nov 12, 2024

  1. WIP: Replace result with custom enum

    @MitchTurner
    MitchTurner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f0ac16d View commit details
    Browse the repository at this point in the history

  2. Finish converting

    @MitchTurner
    MitchTurner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    48d752b View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG

    @MitchTurner
    MitchTurner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0e8720a View commit details
    Browse the repository at this point in the history

  4. Fix spelling--unrelated to branch purpose

    @MitchTurner
    MitchTurner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d1c5a2a View commit details
    Browse the repository at this point in the history

  5. Remove redundant returns

    @MitchTurner
    MitchTurner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    894d8de View commit details
    Browse the repository at this point in the history

  6. Update crates/services/p2p/src/service.rs

    @MitchTurner
    MitchTurner authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    81e1a90 View commit details
    Browse the repository at this point in the history

  7. Revert file back to master

    @MitchTurner
    MitchTurner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b091adf View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'master' into chore/introduce-task-result-enum

    @MitchTurner
    MitchTurner authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3b3b9cd View commit details
    Browse the repository at this point in the history

  2. Fix new compilation errors from master merge

    @MitchTurner
    MitchTurner committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4648b49 View commit details
    Browse the repository at this point in the history

  3. Add helper to v0 code

    @MitchTurner
    MitchTurner committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    78c2940 View commit details
    Browse the repository at this point in the history

  4. Cleanup noisy code

    @MitchTurner
    MitchTurner committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    81c9d22 View commit details
    Browse the repository at this point in the history

  5. Remove should_continue method

    @MitchTurner
    MitchTurner committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8495bc9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Merge branch 'master' into chore/introduce-task-result-enum

    @MitchTurner
    MitchTurner authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    268bd1c View commit details
    Browse the repository at this point in the history

  2. Cover missing error case, reformat expression

    @MitchTurner
    MitchTurner committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    3538282 View commit details
    Browse the repository at this point in the history

  3. Rename function and type

    @MitchTurner
    MitchTurner committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    f8e9649 View commit details
    Browse the repository at this point in the history

  4. Add missed rename

    @MitchTurner
    MitchTurner committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    63b45b3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into chore/introduce-task-result-enum

    @MitchTurner
    MitchTurner authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    747030c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'master' into chore/introduce-task-result-enum

    @xgreenx
    xgreenx authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    cea56f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Merge branch 'master' into chore/introduce-task-result-enum

    @MitchTurner
    MitchTurner authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9481e5c View commit details
    Browse the repository at this point in the history

  2. Make minor touch-ups

    @MitchTurner
    MitchTurner committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    948dfb8 View commit details
    Browse the repository at this point in the history