Consistent strum confirm animation lengths #2522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesisfeline
approved these changes
May 18, 2024
KutikiPlayz
changed the title
EliteMasterEric
added
status: pending triage
EliteMasterEric
added
type: minor bug
KutikiPlayz
changed the title
EliteMasterEric
added
the
size: medium
ninjamuffin99
force-pushed
the
develop
branch
2 times, most recently
from
e0b1b01 to
410cfe9
Compare
KutikiPlayz
force-pushed
the
consistent-strum-anim-lengths
branch
from
7ce1d9a to
94c8215
Compare
KutikiPlayz
force-pushed
the
consistent-strum-anim-lengths
branch
from
0b3e5db to
32ad5f1
Compare
KutikiPlayz
force-pushed
the
consistent-strum-anim-lengths
branch
from
3cf75e4 to
e03c8c6
Compare
KutikiPlayz
force-pushed
the
consistent-strum-anim-lengths
branch
2 times, most recently
from
592608d to
0bbeebc
Compare
|
This PR has merge conflicts, please fix them! |
* aaaaAAAAAAAAAAAAAAAA Actually fix vocals (and other sounds) playing in the chart editor...... ...I think * forgot vocals aren't included
Hundrec
added
status: needs revision
Also they now dance to Artistic Expression
KutikiPlayz
force-pushed
the
consistent-strum-anim-lengths
branch
from
0bbeebc to
7a0ed91
Compare
KutikiPlayz
force-pushed
the
consistent-strum-anim-lengths
branch
from
b5563c5 to
faa3dd9
Compare
Hundrec
added
status: pending triage
AbnormalPoof
added
status: needs revision
AbnormalPoof
requested changes
Jul 29, 2025
|
Closing this because #6261 was merged. |
Hundrec
added
status: duplicate
|
This pull request is a duplicate. Please direct all discussion to the original pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the strum confirm timer to start when the animation is played rather than once it's complete.
Example of what this would look like in gameplay, before, the base notestyle confirm anim would last around 0.2667 seconds, while the pixel notestyle confirm anim would last around 0.1833 seconds. Now, they both (and any other custom notestyles) will last 0.15 seconds.
I'm not entirely sure if this is intended or not, but personally I think this looks better regardless.
Also fixes the strums playing the confirm animation twice on sustain notes.
strum.shit.mp4