[BUGFIX/ENHANCEMENT] Sustain trail alpha fix

[Itsgithubfellow]

Sustain trail alpha would always default to 1 regardless of what alpha value was defined. Simply moving the alpha value into update() fixes this issue. This is similar to pre-rewrite sustain trails which were also semi-transparent.

[nebulazorua]

Why do it in the update? Also why remove the existing alpha = 1.0?
Are we sure it's a bug and not an intentional visual change? Commented out code suggests that's the case (the aforementioned removed alpha = 1.0 with the commented alpha = 0.6)

The code suggests to me that it was meant to become fully opaque when you hit the hold, similar to other VSRGs which make held holds lighter (ITG immediately springs to mind)

Maybe I'm wrong? Personally I'd just make it alpha in the create tho, not the update

[Itsgithubfellow]

Why do it in the update? Also why remove the existing alpha = 1.0? Are we sure it's a bug and not an intentional visual change? Commented out code suggests that's the case (the aforementioned removed alpha = 1.0 with the commented alpha = 0.6)

The code suggests to me that it was meant to become fully opaque when you hit the hold, similar to other VSRGs which make held holds lighter (ITG immediately springs to mind)

Maybe I'm wrong? Personally I'd just make it alpha in the create tho, not the update

I tried editing the existing alpha = 1.0 and it did not change anything, also I believe if this was intentional Eric would've rejected this like he did with another PR that wanted to bring back the old hold anim system.

[lemz1]

I tried editing the existing alpha = 1.0 and it did not change anything

in Strumline.hx there is this line: note.holdNoteSprite.alpha = 1.0;
this is why changing it in create didnt do anything
you would need to change this to 0.6

Are we sure it's a bug and not an intentional visual change? Commented out code suggests that's the case (the aforementioned removed alpha = 1.0 with the commented alpha = 0.6)

Maybe @FunkinCrew considers using the old alpha value, which could be why @EliteMasterEric didn't reject this.

[Itsgithubfellow]

Oh, I never saw that LOL, woops...
I guess that would be a better fix, I'm not sure what performance issues having `alpha = 0.6' in update would bring, if any.

[Itsgithubfellow]

Just tested it out, it only applies the alpha when the note is being pressed, even when the alpha is changed in SustainTrail.hx

2024-06-24.19-58-00.mp4

[lemz1]

then you will have to look for all lines of code that change holdNotesprite.alpha. Probably most of it will be found in strumline and playstate

[anysad]

Just tested it out, it only applies the alpha when the note is being pressed

maybe you forgot to change the alpha in buildHoldNoteSprite() function in Strumline.hx?

[anysad]

2024-06-25.18-31-29.mp4

if you change it to the desired 0.6 alpha, then it becomes just like in the good old days

[Itsgithubfellow]

Oh wow, that is a large oversight on my part. I thought everything would've been handled within SustainTrail.hx, good catch, and a WAYY better fix than mine

[EliteMasterEric]

which could be why @EliteMasterEric didn't reject this.

For the record, status: pending triage means I haven't looked into an issue, I have been just tagging issues as they come in because the issue template isn't doing that for me right now.

I messaged Dave about it but my recollection is that opaque holds were an intentional change. I will definitely merge the other PR that fixes the issue with mods changing opacity regardless.

[EliteMasterEric]

Yeah the opacity change was intentional.