Enable auto-pause for Video Cutscenes#2902
Closed
AbnormalPoof wants to merge 2 commits intoFunkinCrew:mainfrom
AbnormalPoof:develop
Closed
Enable auto-pause for Video Cutscenes#2902AbnormalPoof wants to merge 2 commits intoFunkinCrew:mainfrom AbnormalPoof:develop
AbnormalPoof wants to merge 2 commits intoFunkinCrew:mainfrom
AbnormalPoof:develop
Conversation
Member
Author
|
Accidentally merging into main... please hold. |
AbnormalPoof
added
the
status: rejected
Hundrec
added
status: duplicate
EliteMasterEric
added
the
size: medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pretty small issue I noticed with Video Cutscenes is that they don't seem to pause when the game loses focus, even with the "Auto Pause" option enabled in the Options menu. Looking at the source code, it's kind of obvious why (autoPause is set to false).
Video Cutscenes will now pause on focus loss depending on if "Auto Pause" is enabled or not!
For HTML5, FlxVideo (the method of Video Playback HTML5 uses) doesn't seem to have an autoPause parameter like hxCodec does, so we're just manually pausing and resuming the Video in PlayState's
onFocus()andonFocusLost()functions.Another thing I'd like to mention is that there's a weird bug with autoPause where if you're on the Pause Screen and regain focus, the Video will resume in the background despite the game being paused. I took the liberty of fixing that, basically we just re-pause the video when we regain focus. It's not that elegant, but it does seem to work from the testing I've done.
Before:
before.mp4
After:
after.mp4