Skip to content

[ENHANCEMENT] Softcoded Freeplay Capsule Week Labels#5249

Merged
AbnormalPoof merged 1 commit intoFunkinCrew:dummy/develop-v0.8.3from
KoloInDaCrib:one-less-hardcoded-thing-yay
Mar 12, 2026
Merged

[ENHANCEMENT] Softcoded Freeplay Capsule Week Labels#5249
AbnormalPoof merged 1 commit intoFunkinCrew:dummy/develop-v0.8.3from
KoloInDaCrib:one-less-hardcoded-thing-yay

Conversation

@KoloInDaCrib
Copy link
Contributor

@KoloInDaCrib KoloInDaCrib commented Jun 18, 2025

Linked Issues

N/A

Description

Makes the little text on the Freeplay Song Capsule for the Song's Week softcodable, considering modded weeks aren't currently able to add them. This PR utilizes FlxTexts and openfl's GlowFilter to achieve this effect.

Screenshots/Videos

image

@github-actions github-actions bot added pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. labels Jun 18, 2025
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: mods Related to the creation or use of mods. topic: freeplay Related to the operation of the Freeplay menu. labels Jun 18, 2025
Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, that works

@Trofem
Copy link
Contributor

Trofem commented Sep 24, 2025

if commits will be resolved, it could be epic.
but i think it is optimized enough.

@KoloInDaCrib KoloInDaCrib changed the base branch from develop to dummy/develop-v0.7.5 September 24, 2025 10:42
@Hundrec Hundrec force-pushed the dummy/develop-v0.7.5 branch 2 times, most recently from 8b38bcf to f47de1b Compare September 27, 2025 12:15
@Hundrec Hundrec changed the base branch from dummy/develop-v0.7.5 to develop October 19, 2025 23:47
@KoloInDaCrib KoloInDaCrib force-pushed the one-less-hardcoded-thing-yay branch 3 times, most recently from b217b90 to 2159aca Compare January 24, 2026 12:23
@KoloInDaCrib
Copy link
Contributor Author

Note that this PR now requires FunkinCrew/funkin.assets#347 to be merged as well, since the font used for the freeplay capsule text is not a default font.

@Hundrec Hundrec added the topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. label Jan 25, 2026
@Hundrec Hundrec force-pushed the develop branch 2 times, most recently from 3829dcb to 5805c31 Compare February 1, 2026 03:24
@Hundrec Hundrec linked an issue Feb 25, 2026 that may be closed by this pull request
@macohi
Copy link
Contributor

macohi commented Feb 25, 2026

Please Speed, I need this.

@EliteMasterEric EliteMasterEric self-requested a review March 7, 2026 08:41
@KoloInDaCrib KoloInDaCrib force-pushed the one-less-hardcoded-thing-yay branch 3 times, most recently from 6346b27 to 408fd56 Compare March 7, 2026 12:17
@EliteMasterEric
Copy link
Member

My biggest concern with this was the addition of a font file to the game's asset folder, to be redistributed with the game, and whether The Funkin' Crew Inc. has permission to do this. There's several fonts that the game uses graphically which we aren't allowed to redistribute the font files for (I think the message at the end of Spaghetti is one).

You're Gone is distributed via Typodermic Fonts, founded by Raymond Larabie, the creator of the font Pricedown (which is used in the logos for both The Price Is Right and Grand Theft Auto), and it is thankfully distributed on their website under the Creative Commons Zero license. So we can redistribute this font.

@TechnikTil
Copy link
Contributor

(I think the message at the end of Spaghetti is one)

spaghetti is... suable media?

@EliteMasterEric EliteMasterEric added this to the 0.8.4 milestone Mar 10, 2026
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Mar 12, 2026
@AbnormalPoof AbnormalPoof changed the base branch from develop to dummy/develop-v0.8.3 March 12, 2026 05:59
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Mar 12, 2026
@AbnormalPoof AbnormalPoof merged commit 34845e2 into FunkinCrew:dummy/develop-v0.8.3 Mar 12, 2026
6 checks passed
@KoloInDaCrib KoloInDaCrib deleted the one-less-hardcoded-thing-yay branch March 12, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. topic: freeplay Related to the operation of the Freeplay menu. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

Bug Report: Modded songs don't show their week in freeplay

7 participants