Skip to content

[BUGFIX] Add Enter/Exit Animation For Character Select Nametags #5260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JackXson-Real
Copy link
Contributor

@JackXson-Real JackXson-Real commented Jun 20, 2025

Linked Issues

Fixes #5259

Description

Makes the character select nametags move with the rest of the transition. Works with both entering and exiting.

Known issue: If you switch characters while entering character select before the transition is finished, the nametag will be slightly offset until you hover over it again.

Screenshots/Videos

Animaion.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. size: huge A huge pull request with more than 500 changes. pr: haxe PR modifies game code. and removed size: huge A huge pull request with more than 500 changes. labels Jun 20, 2025
@JackXson-Real JackXson-Real changed the base branch from main to develop June 20, 2025 20:14
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. size: medium A medium pull request with 100 or fewer changes. labels Jun 20, 2025
Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the first thing that bugged me when I originally played the pico update

good PR, I approve

@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Jun 23, 2025
@JackXson-Real
Copy link
Contributor Author

Update: The known issue stated in the description is now fixed thanks to @KoloInDaCrib, and the code is now cleaned up too like @Lasercar wanted

@JackXson-Real JackXson-Real requested a review from Lasercar June 23, 2025 18:16
Copy link
Contributor

@Lasercar Lasercar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KoloInDaCrib @JackXson-Real

2025-06-25.14-36-20.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Character Select Nametags Don't Have Enter/Exit Transition
4 participants