Skip to content

[ENHANCEMENT] Stage Editor - Null characters and open target song stage with song characters #5264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Jun 24, 2025

Linked Issues

Fixes #3850

Description

#4116 this and #4114 this but for the stage editor too.

There's one strange issue I noticed, opening the character data toolbox when there's a null character, without changing characters sets test bf z-index to 0?

Note, there's bound to be issues with this awkward way of allowing null test characters in the stage editor, but nothing that can't be changed or fixed in the future I'm sure.

Screenshots/Videos

Test characters can start as null (can't be set as null though, as that's more work and kinda useless anyway):
screenshot-2025-06-24-20-30-05
screenshot-2025-06-24-20-35-36

Opening the stage of a song in freeplay:

2025-06-24.21-26-44.1.mp4

Opening the stage of playstate song:

2025-06-24.21-39-38.mp4

Also, nullable test characters (but it's buggy)
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels Jun 24, 2025
@Lasercar
Copy link
Contributor Author

Oh, also, opening the stage editor on stress causes this polymod error for whatever reason:

Screenshot 2025-06-24 220057

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: stage editor Related to the operation of the Stage Editor. status: pending triage Awaiting review. labels Jun 25, 2025
@Lasercar Lasercar changed the base branch from develop to main July 2, 2025 06:17
@Lasercar Lasercar changed the base branch from main to develop July 2, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: stage editor Related to the operation of the Stage Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Old Stage Editor keybind active and breaks gameplay
2 participants