Skip to content

[BUGFIX] Load FreeplayStyles on asset reload.#5286

Merged
Hundrec merged 1 commit intoFunkinCrew:developfrom
Keoiki:freeplaystyle-reload-fix
Jul 7, 2025
Merged

[BUGFIX] Load FreeplayStyles on asset reload.#5286
Hundrec merged 1 commit intoFunkinCrew:developfrom
Keoiki:freeplaystyle-reload-fix

Conversation

@Keoiki
Copy link
Contributor

@Keoiki Keoiki commented Jul 3, 2025

Does this PR close any issues? If so, link them below.

#5285

Briefly describe the issue(s) fixed.

This PR fixes freeplay styles not being reloaded on asset reloads (F5), so changes to them will now display in-game without needing to restart it completely :D

@github-actions github-actions bot added size: tiny A tiny pull request with 4 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: tiny A tiny pull request with 4 or fewer changes. labels Jul 3, 2025
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. size: tiny A tiny pull request with 4 or fewer changes. labels Jul 3, 2025
@AbnormalPoof AbnormalPoof self-requested a review July 3, 2025 06:59
@Hundrec Hundrec linked an issue Jul 3, 2025 that may be closed by this pull request
3 tasks
@AbnormalPoof
Copy link
Member

my bad for leaving this open for 4 days lol lmao lol buble

@AbnormalPoof AbnormalPoof added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Jul 7, 2025
@Hundrec Hundrec merged commit 6674c15 into FunkinCrew:develop Jul 7, 2025
7 checks passed
@AbnormalPoof AbnormalPoof added this to the 0.7.0 - Mobile Port milestone Jul 7, 2025
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Jul 7, 2025
@Hundrec Hundrec removed the request for review from AbnormalPoof July 7, 2025 12:17
Copy link
Member

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is GROOVY and not GLOOBY

@Keoiki Keoiki deleted the freeplaystyle-reload-fix branch July 7, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

Bug Report: FreeplayStyleRegistery entries are not reloaded on asset reloads.

3 participants