Skip to content

[BUGFIX] Fix Legacy Chart Import Not Applying Scroll Speed#5655

Merged
Hundrec merged 3 commits intoFunkinCrew:dummy/develop-v0.7.3from
VirtuGuy:fix-legacy-chart-scroll-speed
Aug 21, 2025
Merged

[BUGFIX] Fix Legacy Chart Import Not Applying Scroll Speed#5655
Hundrec merged 3 commits intoFunkinCrew:dummy/develop-v0.7.3from
VirtuGuy:fix-legacy-chart-scroll-speed

Conversation

@VirtuGuy
Copy link
Contributor

@VirtuGuy VirtuGuy commented Aug 3, 2025

Linked Issues

Fixes #5535

Description

When you go into the chart editor and you import a legacy chart, the scroll speed doesn't get applied properly and this pr fixes that so that instead of the scroll speed defaulting to 1, it gets set to the legacy chart's proper scroll speed.

Screenshots/Videos

A screenshot of what the scroll speed should be when importing a legacy chart such as Philly (Hard).

Screenshot 2025-08-03 184839

@github-actions github-actions bot added status: pending triage Awaiting review. size: tiny A tiny pull request with 4 or fewer changes. pr: haxe PR modifies game code. labels Aug 3, 2025
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. labels Aug 3, 2025
@Hundrec Hundrec linked an issue Aug 6, 2025 that may be closed by this pull request
3 tasks
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Aug 6, 2025
@Hundrec Hundrec force-pushed the dummy/develop-v0.7.3 branch from c343cd6 to a87eb25 Compare August 17, 2025 02:13
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Aug 21, 2025
@Hundrec Hundrec added this to the 0.7.4 milestone Aug 21, 2025
@Hundrec Hundrec merged commit 241ff40 into FunkinCrew:dummy/develop-v0.7.3 Aug 21, 2025
6 checks passed
@VirtuGuy VirtuGuy deleted the fix-legacy-chart-scroll-speed branch August 21, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

Bug Report: The Chart Editor doesn’t read scroll speed from FNF Legacy charts

3 participants