Skip to content

Add proper HashLink support #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Add proper HashLink support #6135

wants to merge 3 commits into from
+96 −34

Conversation

@NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented Sep 25, 2025 •
edited
Loading

Linked Issues

Closes #4138

Description

This is quite an old branch of mine that's been sitting on my repository since 2024, finally becoming a PR now that there seems to be a growing interest in building for HashLink. It aims to fix issues that would prevent someone from compiling to HashLink, which could be a pretty useful target for easily making and testing PRs like I did when making #3574.

Feel free to try it out and report any issues you have in the replies!

NOTE: Use the hmm file below to use the forks with the proper fixes for HashLink.
https://gist.github.com/NotHyper-474/deda870cdc722300982c7814ad5c1254

Dependent on:

Known Issues

  • DropShadowShader is utterly broken. Fixed by larsiusprime/polymod@045372c (#258)
  • Advancing in a Conversation causes a crash. Also fixed by the commit above.
  • Chart Editor may randomly crash while messing around. Turns out it's just a bug with HaxeUI.
  • Video cutscenes don't work (which was already expected)
  • Lime can build but cannot open a debug session. Fixed!
  • WiggleEffect shader crashes the game by trying to cast an enum to an int. Fixed by OpenFL PR.
  • Some Focus Camera events aren't able to be properly parsed, which causes a crash.

Screenshots/Videos

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. labels Sep 25, 2025
@AbnormalPoof AbnormalPoof added the type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression label Sep 25, 2025
@EliteMasterEric
Copy link
Member

EliteMasterEric commented Sep 25, 2025

If any features have to be disabled (like video cutscenes), you should make sure to disable them in the project.hxp so that the default build flags enable successful builds.

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 26, 2025

Oh my lord please work.

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

VSlice_HL_COMPILING.zip
That'll fix anything related to lime 👍

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

I keep getting an error when compiling to Hashlink that doesn't happen with windows:
image

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Sep 27, 2025 •
edited
Loading

I keep getting an error when compiling to Hashlink that doesn't happen with windows:
image

That's because you need the change from FunkinCrew/openfl#7

Maybe I should put back the commits from the PRs in the hmm file...

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

I keep getting an error when compiling to Hashlink that doesn't happen with windows:
image

That's because you need the change from FunkinCrew/openfl#7

Maybe I should put back the commits from the PRs in the hmm file...

thatd make it ezer 😅

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

ill test it soon

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

openfl library doesn't seem to be my friend...
image

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Sep 27, 2025

Pull the commit I just pushed and try again, I forgot my fork had a different name lel

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

image

another error but I have a fix for this cuz its happened to me be4

PolymodAbstractScriptClass.txt(txt becuz github's a [[uh-oh]])

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

HUH
image

sphis-sinco
sphis-sinco reviewed Sep 27, 2025
View reviewed changes
Copy link
Contributor

@sphis-sinco sphis-sinco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works but (I'm suspecting) lime keeps fucking it over. Least for me.

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Sep 27, 2025

I think you may need to rebuild Lime for HashLink with lime rebuild hl. I'll look into including Windows binaries tomorrow (currently I only have Linux ones) so that rebuilding isn't necessary.

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 27, 2025

image

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Sep 28, 2025

I managed to rebuild HL on Windows, but for some reason the game just refuses to open bruh, this is some freaking bullshit.

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 28, 2025

image im just being hated

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Sep 28, 2025

image im just being hated 
cd .haxelib/lime/git
git submodule sync
git submodule update --init
cd ../../..

Then try again, hmm doesn't usually update the submodules properly

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 28, 2025

oh ok

@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 28, 2025

ok yeah game didnt open for some reason

@NotHyper-474 NotHyper-474 changed the title Make the HashLink target work Add proper HashLink support Sep 28, 2025
@sphis-sinco
Copy link
Contributor

sphis-sinco commented Sep 28, 2025

kk

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. and removed size: large A large pull request with more than 100 changes. labels Oct 7, 2025
@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Oct 7, 2025 •
edited
Loading

Decided to remove the changes to the hmm file and put them in a gist I've included in the description, I'll be updating it as needed.

@NotHyper-474 NotHyper-474 force-pushed the hashlink-patches branch 10 times, most recently from 739e83b to 4b94149 Compare October 15, 2025 19:01
@NotHyper-474 NotHyper-474 force-pushed the hashlink-patches branch 4 times, most recently from 6eadff7 to cb0c526 Compare October 20, 2025 20:05
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Oct 20, 2025
@NotHyper-474 NotHyper-474 force-pushed the hashlink-patches branch 4 times, most recently from aed15fd to d17be7e Compare October 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sphis-sinco sphis-sinco sphis-sinco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NotHyper-474 @EliteMasterEric @sphis-sinco @AbnormalPoof