Skip to content

[ENHANCEMENT/BUGFIX] Fix double hold note confirm animations / small StrumlineNote rewrite #6391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ENHANCEMENT/BUGFIX] Fix double hold note confirm animations / small StrumlineNote rewrite #6391

wants to merge 1 commit into from

Conversation

@PurSnake
Copy link
Contributor

@PurSnake PurSnake commented Nov 1, 2025 •
edited
Loading

Linked Issues

#6379

Description

I slightly rewrote StrumlineNote to run confirm-hold animation, only if there's correct data is present for that animation. (if it not looped)
Otherwise we just hold last frame of confirm animation 😁

Also added holding variable to prevent unnecessary actions.

Screenshots/Videos

Before:
before

After:
Funkin_FhA7lWSvWT

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Nov 1, 2025
@AbnormalPoof AbnormalPoof added the type: enhancement Involves an enhancement or new feature. label Nov 2, 2025
JackXson-Real
JackXson-Real approved these changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@JackXson-Real JackXson-Real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm JackXson-Real, and I approve this Pull Request!

@PurSnake PurSnake changed the title [ENHANCEMENT] A bit rewrite of StrumlineNote / Twice-playing confirm animation fix [ENHANCEMENT/BUGFIX] Twice-confirm animation fix on hold notes / small StrumlineNote rewrite Nov 3, 2025
@Hundrec Hundrec changed the title [ENHANCEMENT/BUGFIX] Twice-confirm animation fix on hold notes / small StrumlineNote rewrite [ENHANCEMENT/BUGFIX] Fix double hold note confirm animations / small StrumlineNote rewrite Nov 15, 2025
@PurSnake PurSnake force-pushed the touch-those-strumnotes branch from f1b4d21 to 83d01be Compare November 20, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackXson-Real JackXson-Real JackXson-Real approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PurSnake @JackXson-Real @AbnormalPoof