[BUGFIX] Fix Old Icon Being Flipped Incorrectly For Flipped Icons #6394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
AbnormalPoof
added
type: minor bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
None
Description
In the game, having it so that the player health icon is flipped makes it so that the old icon is flipped incorrectly. This PR (of course) fixes this by setting
flipXto true for the old icon (because player icons are normally flipped). Yes, the icon does properly go back to how it was before if you were to change the icon back.I probably made this sound confusing, but to help explain what I mean, characters can have
healthIcondata where you can haveflipXset to true, but for the player, having it set to true really means false.Screenshots/Videos
FNF if it was good... or if you're playing the game with this PR:
My organs failed trying to explain this. "Flipped" was used way too much in the making of this PR.