[FIX] FileUtil#sanitizePath not working correctly on Linux
#6395
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
NotHyper-474
force-pushed
the
lunix/sanitize-fix
branch
from
6d6810c to
bf415ba
Compare
NotHyper-474
force-pushed
the
lunix/sanitize-fix
branch
from
bf415ba to
f47753d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
None, though it came from this report of a mod failing to create a file on Linux on the Discord server
Description
There's some inconsistency with how
fullPathwhich is used bysanitizePathworks on Linux and Windows, on the former it will return null if the path doesn't exist and on the latter it'll work regardless, ironic considering that the documentation for the function in HXCPP says it shouldn't be used like that in these cases.The fact it returns null means that on Linux using
FileUtil.writeStringToPathwould fail on most cases.Screenshots/Videos
Kooha-2025-11-02-23-06-44.webm