Skip to content

[FEATURE] Blacklisted Class macro #6407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

[FEATURE] Blacklisted Class macro #6407

wants to merge 5 commits into from
+473 −218

Conversation

@NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented Nov 7, 2025 •
edited
Loading

Linked Issues

Fixes #6377

Description

Implementation of a handy macro, originally envisioned by AbnormalPoof, that automatically generates blacklisted versions of functions, or wrappers that point to the original functions, for a sandboxed class.

Open to suggestions 👀

Screenshots/Videos

N/A

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. and removed status: pending triage Awaiting review. labels Nov 7, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. labels Nov 7, 2025
@NotHyper-474 NotHyper-474 marked this pull request as draft November 7, 2025 18:14
@github-actions github-actions bot added size: huge A huge pull request with more than 500 changes. and removed size: large A large pull request with more than 100 changes. labels Nov 7, 2025
@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Nov 15, 2025
@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Nov 17, 2025 •
edited
Loading

So for some reason I always get this error when trying to use this fucking macro on FileUtil
image

All leads point to the functions browseBinaryFile and browseTextFile, for whatever reason the fact they use HaxeUI's Dialogs causes this. This seems like some really fucked up Haxe bug, so I just fucking give up on trying to fucking fix it.

@NotHyper-474
Blacklisted class macro
ac7e088 
Macro that automatically generates fields for use in sandboxed classes.
@NotHyper-474
WIP on property overrides
d17614a
@NotHyper-474
Fix incorrect blacklist of Assets classes
f126698 
Those already have import aliases to `funkin.Assets` which is sandboxed against the mentioned `resolveClass` method.
@NotHyper-474
Make funkin.Assets use the blacklist macro
563eb5a
@NotHyper-474
Minor refactor
17213b6
@NotHyper-474 NotHyper-474 changed the base branch from develop to main November 22, 2025 21:12
@NotHyper-474 NotHyper-474 changed the base branch from main to develop November 22, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: huge A huge pull request with more than 500 changes. status: needs revision Cannot be approved because it is awaiting some work by the contributor. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: lime.utils.Assets and openfl.utils.Assets both get an import alias and then get blacklisted

3 participants

@NotHyper-474 @AbnormalPoof @Hundrec